Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add final mainnet balance #5597

Merged
merged 16 commits into from
Aug 12, 2024
Merged

Add final mainnet balance #5597

merged 16 commits into from
Aug 12, 2024

Conversation

ikem-legend
Copy link
Member

What was the problem?

This PR resolves #5596

How was it solved?

  • Add final balance
  • Remove Request / Send / view all tokens button
  • Remove Transactions / Events tabs
  • Add Download Account History button

How was it tested?

  • Unit test

@ikem-legend ikem-legend self-assigned this Jul 30, 2024
Copy link
Member

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Token claim on the testnet is not working, (also good to check mainnet too)
Invalid signature request initiated from another application/network.
Please switch application/network to selected value during connection initialization
  • For mainnet, if we connect with the address without balance, it shows error. (on mainnet or testnet). Can we show 0 balance instead?
  • For testnet, it shows network error. Can we show 0 or unknown?
  • Can we hide the history button on testnet?

@ikem-legend ikem-legend requested a review from shuse2 July 31, 2024 12:30
@shuse2
Copy link
Member

shuse2 commented Aug 1, 2024

When i changed to testnet, i had attached error.
Screenshot 2024-08-01 at 09 23 58
Also, wallet page is not shown anywhere, i think we should bring it back?

shuse2
shuse2 previously approved these changes Aug 9, 2024
@ikem-legend ikem-legend requested a review from shuse2 August 12, 2024 11:32
@shuse2 shuse2 merged commit 24cef21 into development Aug 12, 2024
4 checks passed
@shuse2 shuse2 deleted the 5596-add-final-balance branch August 12, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add final balance and history download
3 participants