Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lisk-service dependencies #5594

Merged
merged 11 commits into from
Jul 25, 2024
Merged

Conversation

shuse2
Copy link
Member

@shuse2 shuse2 commented Jun 3, 2024

What was the problem?

This PR resolves #5580

How was it solved?

  • Remove lisk-service dependencies
  • Remove features that uses lisk-service

How was it tested?

Manually test all paths

  • Token migration
  • Account management
  • verify / sign

@shuse2 shuse2 requested a review from ikem-legend June 3, 2024 15:15
@shuse2 shuse2 self-assigned this Jun 3, 2024
@shuse2 shuse2 requested a review from clemente-xyz June 4, 2024 07:15
clemente-xyz
clemente-xyz previously approved these changes Jul 19, 2024
Copy link
Member

@clemente-xyz clemente-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ikem-legend ikem-legend requested a review from clemente-xyz July 24, 2024 13:36
@shuse2 shuse2 merged commit e49c4f3 into development Jul 25, 2024
4 checks passed
@shuse2 shuse2 deleted the 5580-remove-service-dependency branch July 25, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable claim message signing without Lisk Service
5 participants