Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced delegate filters in s breakpoint - Closes #368 #544

Merged
merged 4 commits into from
Mar 19, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Mar 12, 2018

What was the problem?

Displayed filters for /main/voting are equally spaced in xs breakpoint, and should be left aligned.

How did I fix it?

Added flex-start direction with margins, and reseted margins in greater Bpoints

How to test it?

Open dev tools and set a (max-width < 414px), verify filter items are no longer spaced equally but left aligned, verify rest of Bpoints behave as expected.

Review checklist

@faival faival self-assigned this Mar 12, 2018
@faival faival requested a review from reyraa March 12, 2018 16:53
@slaweet slaweet changed the base branch from 0.3.0 to 0.4.0 March 16, 2018 15:14
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Pablo

@faival faival merged commit ff30cfc into 0.4.0 Mar 19, 2018
@faival faival deleted the 368-misplaced-delegate-filters-in-s-breakpoint branch March 19, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants