Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented additional value column on transaction table #5410

Merged
merged 8 commits into from
Oct 30, 2023
Merged

Implemented additional value column on transaction table #5410

merged 8 commits into from
Oct 30, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Oct 29, 2023 •
edited
Loading

What was the problem?

This PR resolves #5348

How was it solved?

  • Introduce the new value column to the transaction monitor table
  • Introduce the new value column and refactor columns on the wallet transaction table
  • Fix failing unit tests

How was it tested?

  • Navigate to the transactions table on the transaction monitor page
  • Navigate to the transactions table on the wallet page
  • The new value column should be visible.

@eniolam1000752 eniolam1000752 self-assigned this Oct 29, 2023
@eniolam1000752 eniolam1000752 marked this pull request as ready for review October 30, 2023 14:24
@ManuGowda ManuGowda self-requested a review October 30, 2023 17:33
@ManuGowda ManuGowda merged commit bb8d78a into release/3.0.0 Oct 30, 2023
@ManuGowda ManuGowda deleted the 5349-introduce-new-transaction-column branch October 30, 2023 17:45
@ManuGowda ManuGowda restored the 5349-introduce-new-transaction-column branch November 17, 2023 17:35
@ManuGowda ManuGowda deleted the 5349-introduce-new-transaction-column branch November 27, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuGowda ManuGowda ManuGowda approved these changes

@oskarleonard oskarleonard oskarleonard approved these changes

Assignees

@eniolam1000752 eniolam1000752

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eniolam1000752 @ManuGowda @oskarleonard