Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date selector issue #5394

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix date selector issue #5394

merged 1 commit into from
Oct 17, 2023

Conversation

eniolam1000752
Copy link
Contributor

What was the problem?

This PR resolves #5380

How was it solved?

  • Fixed date selector style

How was it tested?

  • Navigate to the blocks or wallet page
  • Click on the filter button
  • Click on the date selector
  • The bug should be fixed.

@eniolam1000752 eniolam1000752 self-assigned this Oct 16, 2023
ManuGowda
ManuGowda reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-10-17 at 9 29 35 AM
Screenshot 2023-10-17 at 9 29 44 AM

Two issues

  • Overlap with new block
  • The new block is not sticking

I think this new block sticking issue fix is what caused the problem at first place i think?

oskarleonard
oskarleonard previously approved these changes Oct 17, 2023
View reviewed changes
@eniolam1000752 eniolam1000752 force-pushed the 5380-fix-date-selector-issue branch from 003e9de to fc6b62e Compare October 17, 2023 09:41
@ManuGowda ManuGowda requested review from ManuGowda and oskarleonard and removed request for ikem-legend October 17, 2023 09:41
@ManuGowda ManuGowda enabled auto-merge October 17, 2023 09:46
@ManuGowda ManuGowda merged commit 5c62652 into release/3.0.0 Oct 17, 2023
5 checks passed
@ManuGowda ManuGowda deleted the 5380-fix-date-selector-issue branch October 17, 2023 09:51
@ManuGowda ManuGowda restored the 5380-fix-date-selector-issue branch November 17, 2023 17:35
@ManuGowda ManuGowda deleted the 5380-fix-date-selector-issue branch November 27, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarleonard oskarleonard oskarleonard approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@eniolam1000752 eniolam1000752

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eniolam1000752 @ManuGowda @oskarleonard