-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous flow for multisig transaction signing #5366
Merged
ManuGowda
merged 33 commits into
release/3.0.0
from
5340-continuous-flow-for-multisig-transaction-signing
Oct 12, 2023
Merged
Continuous flow for multisig transaction signing #5366
ManuGowda
merged 33 commits into
release/3.0.0
from
5340-continuous-flow-for-multisig-transaction-signing
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarleonard
requested review from
ManuGowda,
ikem-legend and
eniolam1000752
and removed request for
ManuGowda and
ikem-legend
October 10, 2023 08:20
ikem-legend
reviewed
Oct 10, 2023
src/modules/transaction/components/Multisignature/Multisignature.js
Outdated
Show resolved
Hide resolved
…for all required wallets that exists in a users account management
ikem-legend
reviewed
Oct 10, 2023
eniolam1000752
suggested changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review comment
- I feel weird not having the copy button at this stage since the download button exists I think also having the copy would be nice to have
- I think in a situation where a user can switch instead of having
share
I think it should beswitch
- Even after switching, I am still on the same account that previously has a signature collected
- This UI seems off
ManuGowda
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ManuGowda
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ikem-legend
reviewed
Oct 12, 2023
ManuGowda
approved these changes
Oct 12, 2023
ikem-legend
approved these changes
Oct 12, 2023
eniolam1000752
approved these changes
Oct 12, 2023
ManuGowda
deleted the
5340-continuous-flow-for-multisig-transaction-signing
branch
October 12, 2023 12:07
ManuGowda
restored the
5340-continuous-flow-for-multisig-transaction-signing
branch
November 17, 2023 17:35
ManuGowda
deleted the
5340-continuous-flow-for-multisig-transaction-signing
branch
November 27, 2023 21:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5340
How was it solved?
Added logic to continue multi sig flow if required accounts exists in users wallet management.
How was it tested?
Case 1 - 3 mandatory accounts in account management
Case 2 - Two Mandatory 1 optional
Case 3 - Two Mandatory (one doesnt exists in your account management)
Case 4 - Edit a multisig account