Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edit stake functionality #5350

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix edit stake functionality #5350

merged 2 commits into from
Oct 2, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Sep 29, 2023 •
edited
Loading

What was the problem?

This PR resolves #5343

How was it solved?

  • Add validatorAddress to editStake dialog button
  • Refactored hasTokenBalance display image logic in data url
  • Fix transactions in block details page

How was it tested?

  • Try to increase the stake amount on an already existing staked validator by an amount lesser than the token balance, it should be observed that there would be no error
  • Try to do this from the validator profile page and from the stakes page

@eniolam1000752 eniolam1000752 self-assigned this Sep 29, 2023
@ManuGowda ManuGowda requested review from ikem-legend and removed request for oskarleonard October 2, 2023 08:44
@ManuGowda ManuGowda merged commit ffce2c9 into release/3.0.0 Oct 2, 2023
@ManuGowda ManuGowda deleted the 5343-fix-stake-chaning branch October 2, 2023 09:17
@ManuGowda ManuGowda restored the 5343-fix-stake-chaning branch November 17, 2023 17:35
@ManuGowda ManuGowda deleted the 5343-fix-stake-chaning branch November 28, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuGowda ManuGowda ManuGowda approved these changes

@ikem-legend ikem-legend ikem-legend approved these changes

Assignees

@eniolam1000752 eniolam1000752

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eniolam1000752 @ManuGowda @ikem-legend