-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent a user from switching to a custom network which fails #5330
Merged
ManuGowda
merged 6 commits into
release/3.0.0
from
5309-switch-to-working-network-from-nonworking
Sep 22, 2023
Merged
Prevent a user from switching to a custom network which fails #5330
ManuGowda
merged 6 commits into
release/3.0.0
from
5309-switch-to-working-network-from-nonworking
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarleonard
requested review from
ikem-legend,
eniolam1000752 and
ManuGowda
September 22, 2023 10:13
eniolam1000752
suggested changes
Sep 22, 2023
src/modules/network/components/networkSwitcherDropdown/NetworkSwitcherDropdown.js
Show resolved
Hide resolved
src/modules/network/components/networkSwitcherDropdown/NetworkSwitcherDropdown.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eniolam1000752
suggested changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ManuGowda
approved these changes
Sep 22, 2023
eniolam1000752
approved these changes
Sep 22, 2023
ManuGowda
deleted the
5309-switch-to-working-network-from-nonworking
branch
September 22, 2023 15:18
ManuGowda
restored the
5309-switch-to-working-network-from-nonworking
branch
November 17, 2023 17:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5309
How was it solved?
Make sure our networkClient is set before making the request. This is to prevent race conditions.
How was it tested?