Change typographical elements to use px - Closes #85 #524
+64
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasharAyari
force-pushed
the
85-change-typographical-elements-to-use-px
branch
2 times, most recently
from
7c3a8cb to
05a8e7f
Compare
slaweet
suggested changes
Mar 7, 2018
There was a problem hiding this comment.
There are still places that use em. You can find them with git grep '[0-9]em'.
I would also consider removing em here:
https://github.com/LiskHQ/lisk-hub/blob/805653beac53411dafc81b991c59fe4643977098/config/webpack.config.react.js#L48
src/components/app/variables.css
Outdated
| --font-size-h1: 65px; | ||
| --font-size-h2: 32px; | ||
| --font-size-h3: 28px; | ||
| --font-size-h4: 26; |
Codecov Report
@@ Coverage Diff @@
## 0.3.0 #524 +/- ##
========================================
Coverage ? 91.82%
========================================
Files ? 184
Lines ? 3072
Branches ? 840
========================================
Hits ? 2821
Misses ? 251
Partials ? 0Continue to review full report at Codecov.
|
slaweet
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
There were some font-size amount in 'em' that needed to be replaced with 'px' ones
Review checklist