Implement application bootstrap component #4815
Conversation
ManuGowda
changed the title
setup/config/webpack.config.dev.js
Outdated
| @@ -27,6 +27,7 @@ const config = { | |||
| new webpack.DefinePlugin({ | |||
There was a problem hiding this comment.
Comment not related to this file
Question: This seems to be unrelated to hardware wallet? Shouldnt we merge this into development?
There was a problem hiding this comment.
@eniola its wrong env you can have .env file in your pc for test propose check this out
https://create-react-app.dev/docs/adding-custom-environment-variables/#what-other-env-files-can-be-used
setup/config/webpack.config.dev.js
Outdated
| @@ -27,6 +27,7 @@ const config = { | |||
| new webpack.DefinePlugin({ | |||
| PRODUCTION: JSON.stringify(false), | |||
| VERSION: JSON.stringify(version), | |||
| DEFAULT_NETWORK: 'devnet', | |||
There was a problem hiding this comment.
no iots wront its should be in .env
and need a prefix of REACT_APP like the REACT_APP_MSW you can find in config file
REACT_APP_ DEFAULT_NETWORK
| }, [isFetched]); | ||
|
|
||
| if (error) { | ||
| // @TODO: this return should be replaced with an actual error message page |
There was a problem hiding this comment.
create a ticket if is not exist and add ticket number to todo
setup/config/webpack.config.dev.js
Outdated
| @@ -27,6 +27,7 @@ const config = { | |||
| new webpack.DefinePlugin({ | |||
There was a problem hiding this comment.
@eniola its wrong env you can have .env file in your pc for test propose check this out
https://create-react-app.dev/docs/adding-custom-environment-variables/#what-other-env-files-can-be-used
What was the problem?
This PR resolves #4707 and #4708
How was it solved?
How was it tested?