Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'npm run dist' on Linux - Closes #477 #481

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fix 'npm run dist' on Linux - Closes #477 #481

merged 1 commit into from
Feb 27, 2018

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Feb 23, 2018

What was the problem?

The problem was that icns icon file was missing 512x512 version

How did I fix it?

Added the missing icon

How to test it?

Run npm run dist on Linux.

Review checklist

@slaweet
Fix 'npm run dist' on Linux - Closes #477
09237d9 
The problem was that icns icon file was missing 512x512 version
@slaweet slaweet self-assigned this Feb 23, 2018
@slaweet slaweet requested a review from ginacontrino February 23, 2018 13:41
ginacontrino
ginacontrino approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@ginacontrino ginacontrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@slaweet slaweet merged commit 853c769 into 0.2.0 Feb 27, 2018
@slaweet slaweet deleted the 477-npm-run-dist-on-linux branch February 27, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ginacontrino ginacontrino ginacontrino approved these changes

Assignees

@slaweet slaweet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaweet @ginacontrino