Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hardware wallet status to top bar #4793

Merged
merged 11 commits into from
Feb 9, 2023
Merged

Add hardware wallet status to top bar #4793

merged 11 commits into from
Feb 9, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Feb 7, 2023 •
edited
Loading

What was the problem?

This PR resolves #4769

How was it solved?

  • Add the hw icon and popover to the topbar
  • Add unit tests

How was it tested?

  • Jest
  • Visually

@eniolam1000752 eniolam1000752 self-assigned this Feb 7, 2023
@eniolam1000752 eniolam1000752 marked this pull request as ready for review February 8, 2023 17:50
oskarleonard
oskarleonard previously approved these changes Feb 9, 2023
View reviewed changes
@eniolam1000752 eniolam1000752 merged commit ea62b14 into feature/adapt-hw Feb 9, 2023
@eniolam1000752 eniolam1000752 deleted the 4769-add-hw-status-to-top-bar branch February 9, 2023 11:27
@eniolam1000752 eniolam1000752 mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikem-legend ikem-legend ikem-legend approved these changes

@oskarleonard oskarleonard oskarleonard approved these changes

Assignees

@eniolam1000752 eniolam1000752

Labels
None yet
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eniolam1000752 @oskarleonard @ikem-legend