Create an integration tests for voting component - Closes #290 #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
suggested changes
Feb 23, 2018
There was a problem hiding this comment.
I see the PR is still in progress, which is why I want to make two suggestions before there are more tests that they need to be applied to:
- Use https://github.com/producthunt/chai-enzyme for assertions, because then it gives a more descriptive error message if the assertion fails then just "Expected false to be true". Some examples are below.
- Use atomic steps. "When ..." step should usually only simulate something (e.g. a click), "Then ..." step should usually only make an assertion. If one step first simulates and then
expects something. E.g. 'Then I confirm my votes' should be two steps 'When I confirm my votes' and 'Then I see a confirmation message' . The step definitions then can be in separate reusable functions like here:
https://github.com/LiskHQ/lisk-hub/blob/df5a7e3e52dfc662eccd6879917071082f747bba/test/integration/wallet.test.js#L216-L225
test/integration/voting.test.js
Outdated
| step('I\'m logged in as "genesis"', () => { loginProcess(); }); | ||
|
|
||
| step('And next button should be disabled', () => { | ||
| expect(wrapper.find('button.next').props().disabled).to.be.equal(true); |
There was a problem hiding this comment.
This would be better as
expect(wrapper.find('button.next')).to.have.prop('disabled', true);
https://github.com/producthunt/chai-enzyme#propkey-val
test/integration/voting.test.js
Outdated
| }); | ||
|
|
||
| step('Then I must be able to go to next step', () => { | ||
| expect(wrapper.find('button.confirm').exists()).to.be.equal(false); |
There was a problem hiding this comment.
This would be better as
expect(wrapper.find('button.confirm')).to.be.not.present();
For the same reason as above.
https://github.com/producthunt/chai-enzyme#present
test/integration/voting.test.js
Outdated
| account, | ||
| }); | ||
| wrapper.find('button.confirm').simulate('click'); | ||
| expect(wrapper.find('h2.result-box-header').text()).to.be.equal(expectedValue); |
There was a problem hiding this comment.
test/integration/voting.test.js
Outdated
| step('I\'m logged in as "genesis"', () => { loginProcess([delegates[0]]); }); | ||
|
|
||
| step('And I should see 3 rows', () => { | ||
| expect(wrapper.find('ul.delegate-row')).to.have.lengthOf(3); |
There was a problem hiding this comment.
slaweet
changed the title
slaweet
approved these changes
Feb 27, 2018
yasharAyari
deleted the
290-implement-integration-test-for-voting-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
There wasn't any integration tests for voting component
-this PR also covers issue #484
Review checklist