Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lisk client to alpha 10 #4696

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

ManuGowda
Copy link
Contributor

@ManuGowda ManuGowda commented Jan 3, 2023

What was the problem?

This PR resolves #4688

How was it solved?

  • Updated lisk client to latest version
  • Handle transaction dry run
    • handled success, fail and error scenario
    • The event error feedback handling require some changes from SDK, so this is still a TODO
  • Fixed a naming issue with transactionID

How was it tested?

  • Unit tests updated
  • Successfully transferred tokens

@ManuGowda ManuGowda self-assigned this Jan 3, 2023
@ManuGowda ManuGowda changed the title 4688 update lisk client Update lisk client to alpha 10 Jan 3, 2023
@ManuGowda ManuGowda force-pushed the 4688-update-lisk-client branch from f9ff7de to 79d4fb5 Compare January 3, 2023 14:04
Update transaction dryrun logic to handle the latest SDK changes
@ManuGowda ManuGowda force-pushed the 4688-update-lisk-client branch from 79d4fb5 to 8126fe3 Compare January 5, 2023 08:16
@ManuGowda ManuGowda marked this pull request as ready for review January 5, 2023 08:35
@ManuGowda ManuGowda force-pushed the 4688-update-lisk-client branch from eaef989 to 03c9476 Compare January 5, 2023 08:48
@ManuGowda ManuGowda force-pushed the 4688-update-lisk-client branch from 03c9476 to 25e6fc2 Compare January 5, 2023 08:57
@ManuGowda ManuGowda merged commit f7825ba into feature/dpos-update Jan 5, 2023
@ManuGowda ManuGowda deleted the 4688-update-lisk-client branch January 5, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants