-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render the recent transactions widget correctly #4676
Merged
ManuGowda
merged 8 commits into
development
from
4593-recent-transactions-widget-not-rendered
Dec 20, 2022
Merged
Render the recent transactions widget correctly #4676
ManuGowda
merged 8 commits into
development
from
4593-recent-transactions-widget-not-rendered
Dec 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
force-pushed
the
4593-recent-transactions-widget-not-rendered
branch
from
December 19, 2022 15:34
8328a5b
to
62a79b2
Compare
ManuGowda
changed the title
Render the recent transactions widget correctly - Closes #4593
Render the recent transactions widget correctly
Dec 20, 2022
ikem-legend
previously approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @reyraa
ManuGowda
reviewed
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reyraa found some UI issues
ManuGowda
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4593
How was it solved?
The widget tried to access transactions list on Redux store, which is the old approach. I replaced them with corresponding hooks.
How was it tested?
Testsed against devnet, and updated the unit tests