Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the recent transactions widget correctly #4676

Merged
merged 8 commits into from
Dec 20, 2022

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Dec 19, 2022

What was the problem?

This PR resolves #4593

How was it solved?

The widget tried to access transactions list on Redux store, which is the old approach. I replaced them with corresponding hooks.

How was it tested?

Testsed against devnet, and updated the unit tests

@reyraa reyraa linked an issue Dec 19, 2022 that may be closed by this pull request
@reyraa reyraa self-assigned this Dec 19, 2022
@reyraa reyraa force-pushed the 4593-recent-transactions-widget-not-rendered branch from 8328a5b to 62a79b2 Compare December 19, 2022 15:34
@reyraa reyraa requested a review from ikem-legend December 19, 2022 16:09
@ManuGowda ManuGowda changed the title Render the recent transactions widget correctly - Closes #4593 Render the recent transactions widget correctly Dec 20, 2022
@reyraa reyraa marked this pull request as ready for review December 20, 2022 11:11
@ManuGowda ManuGowda self-requested a review December 20, 2022 12:41
ikem-legend
ikem-legend previously approved these changes Dec 20, 2022
Copy link
Member

@ikem-legend ikem-legend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @reyraa

Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ManuGowda ManuGowda merged commit fc87a86 into development Dec 20, 2022
@ManuGowda ManuGowda deleted the 4593-recent-transactions-widget-not-rendered branch December 20, 2022 14:51
@ManuGowda ManuGowda restored the 4593-recent-transactions-widget-not-rendered branch November 17, 2023 17:36
@ManuGowda ManuGowda deleted the 4593-recent-transactions-widget-not-rendered branch November 27, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Recent transactions widget not rendered
3 participants