Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main menu to show in IE 11 - Closes #446 #447

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Feb 20, 2018

What was the problem?

The problem was that classList.add() doesn't work with multiple
arguments in IE.

How did I fix it?

Used two separate classList.add()

How to test it?

Open the app in IE 11

Review checklist

the problem was that classList.add() doesn't work with multiple
arguments in IE
@slaweet slaweet self-assigned this Feb 20, 2018
@slaweet slaweet requested a review from yasharAyari February 20, 2018 08:16
@slaweet slaweet force-pushed the 466-fix-main-menu-in-ie branch from 248789b to ab9ffa7 Compare February 20, 2018 08:57
Copy link
Contributor

@yasharAyari yasharAyari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job.

@slaweet slaweet merged commit 9f384aa into 0.1.0 Feb 20, 2018
@slaweet slaweet deleted the 466-fix-main-menu-in-ie branch February 20, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants