Create details dialog for application exploring - Closes #4356, #4357 #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eniolam1000752
requested review from
isalga and
soroushm
and removed request for
soroushm and
isalga
eniolam1000752
changed the title
soroushm
reviewed
Jun 30, 2022
...nApplication/explore/components/BlockchainApplicationDetails/BlockchainApplicationDetails.js
Outdated
Show resolved
Hide resolved
...nApplication/explore/components/BlockchainApplicationDetails/BlockchainApplicationDetails.js
Outdated
Show resolved
Hide resolved
| </div> | ||
| <div className={styles.balanceRow}> | ||
| <span>Deposited:</span> | ||
| <span>5,351.859 LSK</span> |
There was a problem hiding this comment.
all the value should come from the variable like data.deposit
ikem-legend
reviewed
Jul 1, 2022
| @@ -11,3 +11,4 @@ export { default as watchList } from '@dpos/validator/store/reducers/watchList'; | |||
| export { default as service } from './service'; | |||
| export { default as loading } from './loading'; | |||
| export { account } from 'src/modules/account/store/reducer'; | |||
| export { blockChainApplications } from 'src/modules/blockchainApplication/explore/store/reducer'; | |||
There was a problem hiding this comment.
@eniolam1000752 This should be aliased along with the previous line
ikem-legend
reviewed
Jul 1, 2022
ikem-legend
reviewed
Jul 1, 2022
ikem-legend
reviewed
Jul 1, 2022
ikem-legend
reviewed
Jul 1, 2022
…56-create-details-dialog-for-app-exploring' of https://github.com/LiskHQ/lisk-desktop into 4356-create-details-dialog-for-app-exploring
soroushm
reviewed
Jul 1, 2022
| lastCertificateHeight: 1000, | ||
| lastUpdated: 123456789, | ||
| deposit: 5e10, | ||
| serviceUrl: 'https://enevti.com/', |
There was a problem hiding this comment.
is the actual response
{
"data": [{
"name": "Test app",
"chainID": "aq02qkbb35u4jdq8szo3pnsq",
"state": "active",
"address": "lsk24cd35u4jdq8szo3pnsqe5dsxwrnazyqqqg5eu",
"lastCertificateHeight": 1000, // Optional
"lastUpdated": 123456789, // Optional
}],
"meta": {
"count": 10,
"offset": 10,
"total": 150,
},
"links": {}
}
ikem-legend
reviewed
Jul 1, 2022
|
@eniolam1000752 Please fix CSS for application status badge |
ikem-legend
previously approved these changes
Jul 4, 2022
soroushm
previously approved these changes
Jul 5, 2022
eniolam1000752
force-pushed
the
4356-create-details-dialog-for-app-exploring
branch
2 times, most recently
from
2b29ea8 to
20cfb58
Compare
Signed-off-by: eniolam1000752 <eniolam1000752@gmail.com>
eniolam1000752
force-pushed
the
4356-create-details-dialog-for-app-exploring
branch
from
20cfb58 to
534e059
Compare
ikem-legend
approved these changes
Jul 5, 2022
soroushm
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4356, #4357
How was it solved?
How was it tested?