Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented password authentication for sign transaction flow - Closes #4301 #4346

Closed
wants to merge 46 commits into from
Closed

Implemented password authentication for sign transaction flow - Closes #4301 #4346

wants to merge 46 commits into from

Conversation

ikem-legend
Copy link
Member

@ikem-legend ikem-legend commented Jun 15, 2022 •
edited by eniolam1000752
Loading

What was the problem?

This PR resolves #4301

How was it solved?

  • Enable users to enter the password for signing any transaction type at the time of creating the transaction

How was it tested?

Manually

reyraa and others added 30 commits June 7, 2022 09:43
@reyraa
Move TransactionSummary
8f3c6bd
@reyraa
Rename TxSignatureCollector
e85cfdd
@reyraa
Rename TxBroadcaster
2d4e57c
@reyraa
Move Send to the token domain
8bcaeed
@reyraa
Use selectAciveTokenAccount
523e424
@reyraa
Create TxComposer
b72bf30
@reyraa
Use TxComposer in UnlockBalance transaction
39596c3 
Signed-off-by: Ali Haghighatkhah <ali@lightcurve.io>
@reyraa
Use TxComposer in register delegate form
ecd7f31
@reyraa
Remove the use of flaten
dc6ddb5 
Signed-off-by: Ali Haghighatkhah <ali@lightcurve.io>
@reyraa
Use TxComposer for vote
dd8e6db
@reyraa
Use TxCompose in SendForm
db4f1c0
@reyraa
Use TxComposer in register multisig form
9f05cea
@reyraa
Update summary of Send
2bc8c38
@reyraa
Update summary of register delegate
260a510
@reyraa
Update summary of unlock balance
e68f85f
@reyraa
Update summary of vote
4394c39
@reyraa
Update summary of register multisig
f470efd
@reyraa
Rename components
5859793
@reyraa
Remove unused props
e13ae48
@reyraa
rewire transaction props
e1efbb6 
Signed-off-by: Ali Haghighatkhah <ali@lightcurve.io>
@reyraa
Rename create and transactionCreated to more descriptive names
25b78c9
@reyraa
Remove flattenTransaction and rename transformTransaction and createT…
078b6e1 
…ransactionObject
@reyraa
Fix the fee value
e4f0176
@reyraa
Rename transactionResult to txBroadcaster
337fa15
@reyraa
Rename TransactionResult to TxBroadcaster
56abee8
@reyraa
Move tokensTransferred action to the token module
eb4de77
@reyraa
Fix dpos transactions
de4a503
@reyraa
Fix the reclaim type
9d02581
@ikem-legend
Merge branch 'feature/blockchain-agnostic-new' into 4301-sign-txn-flo…
cb95b28 
…w-with-password
@ikem-legend
Initial setup of txn password verification
42714a7
@ikem-legend ikem-legend requested review from reyraa and soroushm June 15, 2022 16:42
@ikem-legend ikem-legend self-assigned this Jun 15, 2022
reyraa and others added 14 commits June 15, 2022 20:44
@ikem-legend ikem-legend marked this pull request as ready for review June 19, 2022 12:10
@ikem-legend
Copy link
Member Author

Closed to resolve history issues

@ikem-legend ikem-legend deleted the 4301-sign-txn-flow-with-password branch June 29, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyraa reyraa Awaiting requested review from reyraa

@soroushm soroushm Awaiting requested review from soroushm

Assignees

@ikem-legend ikem-legend

Labels
None yet
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikem-legend @reyraa