Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement setup password success - Closes #4294 #4326

Merged
merged 7 commits into from
May 30, 2022
Merged

Implement setup password success - Closes #4294 #4326

merged 7 commits into from
May 30, 2022

Conversation

gadjacobs
Copy link
Contributor

@gadjacobs gadjacobs commented May 25, 2022 •
edited
Loading

What was the problem?

This PR resolves #4294

How was it solved?

  • Implement setup your password success according to design
  • Implement encrypted JSON file download button
  • Add unit tests to Validate encrypted JSON file

How was it tested?

  • Visually
  • Unit tests

@gadjacobs gadjacobs self-assigned this May 25, 2022
@gadjacobs gadjacobs marked this pull request as ready for review May 30, 2022 04:20
@gadjacobs gadjacobs requested review from soroushm and isalga May 30, 2022 04:35
isalga
isalga reviewed May 30, 2022
View reviewed changes
Copy link
Contributor

@isalga isalga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reduce padding between button and bottom

@gadjacobs gadjacobs merged commit 91b2ff6 into feature/blockchain-agnostic-new May 30, 2022
@gadjacobs gadjacobs deleted the 4294-implement-setup-password-success branch May 30, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isalga isalga isalga approved these changes

@soroushm soroushm soroushm approved these changes

Assignees

@gadjacobs gadjacobs

Labels
None yet
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gadjacobs @soroushm @isalga