Remove sign in and sign out features - Closes #4317, #4463 #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isalga please don't merge the pr when is done |
soroushm
suggested changes
May 31, 2022
ikem-legend
previously approved these changes
May 31, 2022
ikem-legend
reviewed
Jun 1, 2022
ikem-legend
reviewed
Jun 1, 2022
ikem-legend
reviewed
Jun 1, 2022
reyraa
previously approved these changes
Jun 1, 2022
ikem-legend
previously approved these changes
Jun 1, 2022
|
This pull request can not be merged unless the change API objective is completed to support the way login to account to be able to create transaction or access endpoints. All of the SDK v5 features are closely integrated, so we intend to keep this PR until v6 API integration is completed. |
ManuGowda
changed the base branch from
feature/blockchain-agnostic-new
to
development
ManuGowda
dismissed stale reviews from ikem-legend and reyraa
The base branch was changed.
soroushm
changed the base branch from
development
to
feature/4034-change-sdk-api
soroushm
force-pushed
the
4317-remove-sign-in-out
branch
from
c886ea1 to
565954e
Compare
eniolam1000752
suggested changes
Aug 17, 2022
| @@ -20,10 +19,10 @@ describe('Reducer: settings(state, action)', () => { | |||
| it('should return updated settings if action.type = actionTypes.settingsUpdated', () => { | |||
| const action = { | |||
| type: actionTypes.settingsUpdated, | |||
| data: { autoLog: false }, | |||
| data: { testSetting: false }, | |||
There was a problem hiding this comment.
the naming convention here seems confusing possibly the term useTestSetting would be okay I think
There was a problem hiding this comment.
@eniolam1000752 we dont need this settings anymore could you please remove it
soroushm
changed the title
soroushm
force-pushed
the
4317-remove-sign-in-out
branch
from
d9e49a2 to
d3874c8
Compare
eniolam1000752
force-pushed
the
4317-remove-sign-in-out
branch
from
8bc1c04 to
e87acfc
Compare
soroushm
force-pushed
the
4317-remove-sign-in-out
branch
from
4d530f0 to
122cb47
Compare
soroushm
approved these changes
Sep 6, 2022
reyraa
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4317
How was it solved?
How was it tested?