Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delegates sent votes tab - Closes #4115 #4120

Closed
wants to merge 47 commits into from
Closed

Fix delegates sent votes tab - Closes #4115 #4120

wants to merge 47 commits into from

Conversation

gadjacobs
Copy link
Contributor

What was the problem?

This PR resolves #4115

How was it solved?

  • fetching sentVotes from the right endpoint

How was it tested?

  • added unit tests

eniolam1000752 and others added 30 commits January 11, 2022 18:07
@eniolam1000752
added optional chaining to dpos properties
a238cee
@eniolam1000752
fix deep scan issues
0981974
@eniolam1000752
fix deep scan issues
f154257
@ManuGowda
Merge branch 'release/2.2.0' into 4067-bookmark-e2e-test-failures
6b17115
@ManuGowda
Merge branch 'release/2.2.0' into 4067-bookmark-e2e-test-failures
2071d91
@eniolam1000752
refactored add Bookmark
ea0c537
@eniolam1000752
Merge branch '4067-bookmark-e2e-test-failures' of https://github.com/…
a35059b 
…LiskHQ/lisk-desktop into 4067-bookmark-e2e-test-failures
@eniolam1000752
refactored addBookmark file
71b48de
@eniolam1000752
refactored chaining on delegateProfile
6665e3b
@eniolam1000752
fixed optional chaining on accounts
7f1d451
@eniolam1000752
refactored optional chaining on delegates
eb5ed65
@eniolam1000752
fix deepscan issue
80a0d96
@eniolam1000752
fixing failing unit test
4c9199e
@eniolam1000752
fix racing issue between login and wallet page visit
cd0affe
@eniolam1000752
refactored Pbased on PR comments
ceb1477
@eniolam1000752
removed some optional chaining
0ac6403
@eniolam1000752
fixed failling unit test
0d139da
@eniolam1000752
fixed failling unit test
855b9a6
@eniolam1000752
resolved unit test issue
3e44f5c
@eniolam1000752
fixing filling unit test
f9ea43c
@eniolam1000752
removed re-dump and restart_serivce sh script
d3fca5a
@reyraa
Merge branch 'release/2.2.0' into 4067-bookmark-e2e-test-failures
36dd431
@ManuGowda
Update DEVELOPMENT_GUIDE.md
82f3189
@ManuGowda
Merge pull request #4073 from LiskHQ/Update-contributing-guidelines
ebeaa09 
Update contributing guidelines - Closes #4072
@ikem-legend
Fixed dark mode display for default last forged block value
e625678
@eniolam1000752
removed forger plugin from core statup in jenkins
7165e42
@reyraa
Merge branch 'release/2.2.0' into development
792e2bc
@dependabot
Bump postcss from 6.0.12 to 8.2.13
ef8d3dd 
Bumps [postcss](https://github.com/postcss/postcss) from 6.0.12 to 8.2.13.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@6.0.12...8.2.13)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@ManuGowda
Merge branch 'release/2.2.0' into 4067-bookmark-e2e-test-failures
b64e1f7
@ManuGowda
Merge branch 'development' into 4067-bookmark-e2e-test-failures
7a88891
reyraa and others added 15 commits January 17, 2022 22:37
@reyraa
Merge branch 'development' into dependabot/npm_and_yarn/postcss-8.2.13
9369a56
@reyraa
Merge pull request #4061 from LiskHQ/dependabot/npm_and_yarn/postcss-…
0cceb77 
…8.2.13

Bump postcss from 6.0.12 to 8.2.13
@ManuGowda
Merge branch 'development' into 4074-last-forged-block-dark-mode
918cff8
@ManuGowda
Merge pull request #4075 from LiskHQ/4074-last-forged-block-dark-mode
59cf59d 
Fixed last forged block default value display in dark mode - Closes #4074
@ikem-legend
Renamed font folder similar to mobile
ab22446
@ikem-legend
Updated Jenkins files with font changes
ada7a9b
@ikem-legend
Updated Jenkins files for font folder rename
c8fc5cc
@reyraa
Merge pull request #4086 from LiskHQ/3956-font-assets-rename
2649cec 
Renamed fonts similar to Lisk mobile - Closes #3956
@ikem-legend
Renamed fonts appropriately
ccabbca
@reyraa
Merge branch release/2.2.0 into development
f2a7316
@ikem-legend
Fixed error in font config in Jenkins files
58f7307
@reyraa
Merge branch 'development' into 3956-font-assets-rename
0e8cd96
@reyraa
Merge pull request #4090 from LiskHQ/3956-font-assets-rename
0390688 
Rename Desktop fonts to match font names in Lisk Mobile - Closes #3956
@reyraa
Fix the data retrieval
472f21c
@gadjacobs
Add unit tests
736f8b8
@gadjacobs gadjacobs requested review from reyraa and ManuGowda January 31, 2022 11:10
@gadjacobs gadjacobs self-assigned this Jan 31, 2022
@ManuGowda ManuGowda changed the base branch from development to release/2.2.0 January 31, 2022 11:23
@ManuGowda ManuGowda changed the base branch from release/2.2.0 to development January 31, 2022 11:25
@gadjacobs gadjacobs changed the base branch from development to release/2.2.0 January 31, 2022 11:29
@gadjacobs gadjacobs closed this Jan 31, 2022
@gadjacobs gadjacobs reopened this Jan 31, 2022
@gadjacobs gadjacobs closed this Jan 31, 2022
@reyraa reyraa deleted the fix-votes-tab branch February 1, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyraa reyraa Awaiting requested review from reyraa

@ManuGowda ManuGowda Awaiting requested review from ManuGowda

Assignees

@gadjacobs gadjacobs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't load votes for other delegates
5 participants
@gadjacobs @eniolam1000752 @ManuGowda @reyraa @ikem-legend