Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate search points to transaction tab - Closes #4023 #4027

Merged
merged 4 commits into from
Dec 30, 2021
Merged

Delegate search points to transaction tab - Closes #4023 #4027

merged 4 commits into from
Dec 30, 2021

Conversation

eniolam1000752
Copy link
Contributor

What was the problem?

This PR resolves #4023

How was it solved?

This issue was solved by adding the tab query param to the accounts route when a delegate search item was clicked

How was it tested?

  • Search for a delegate
  • Click on any of the delegates that appear in the suggestion list
  • you should be routed to the delegate profile page not delegate transactions

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@eniolam1000752 eniolam1000752 changed the title Delegate search points to transaction tab - Closes #1234 Delegate search points to transaction tab - Closes #4023 Dec 26, 2021
@eniolam1000752 eniolam1000752 self-assigned this Dec 26, 2021
@gadjacobs
Copy link
Contributor

@eniolam1000752 you may need to sign the CLA first before the branch can be properly built

@ManuGowda ManuGowda changed the base branch from development to release/2.2.0 December 28, 2021 15:06
reyraa
reyraa approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @eniolam1000752

@reyraa reyraa removed the request for review from isalga December 30, 2021 09:54
@reyraa reyraa merged commit 650d5bb into release/2.2.0 Dec 30, 2021
@welcome
Copy link

welcome bot commented Dec 30, 2021

Congrats on merging your first pull request! Ready for new challenges? You can find your next issue here

@reyraa reyraa deleted the 4023-point-delegate-search-to-delegate-profile branch December 30, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadjacobs gadjacobs gadjacobs approved these changes

@reyraa reyraa reyraa approved these changes

Assignees

@eniolam1000752 eniolam1000752

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delegate search points to transaction tab
5 participants
@eniolam1000752 @CLAassistant @gadjacobs @reyraa @ManuGowda