Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HW multisig support - Closes #3954 #3997

Merged
merged 27 commits into from
Jan 10, 2022

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Dec 5, 2021

What was the problem?

This PR resolves #3954

How was it solved?

  • Moved the signature functions to tx utilities.
  • Use the above utilities to sign multisig txs A. when creating, B. when signing txs of the group.
  • Add second signature if the registrant is a member too.
  • Normalize the parameters and clean up the code.
  • Adapt and increase unit tests.

Extra

  • Fix validation in case members are all optional.
  • Fix noop errors thrown because of repeated component key.
  • Fix noop errors thrown because of unrecognized properties.

How was it tested?

  • Fixed broken unit tests
  • Tested manually

@reyraa reyraa self-assigned this Dec 5, 2021
@reyraa reyraa requested a review from ManuGowda December 5, 2021 21:35
@reyraa reyraa force-pushed the 3954-add-hw-multisig-support branch from 8a9db1e to 940b555 Compare December 27, 2021 22:23
@ManuGowda
Copy link
Contributor

@ManuGowda
Copy link
Contributor

Tested token transfer from HW multi-signature account: https://testnet.liskscan.com/transaction/7ab52e15b3702f9a49c72612767be5e3835c27910cb7690fc45d59ff6d756eb0

Tested multi signature account registration from HW multi-signature account: https://testnet.liskscan.com/transaction/76259d2129be57b32ddd58eec4e649abd691e2980e282ff54c2d629b32395f13

@reyraa reyraa force-pushed the 3954-add-hw-multisig-support branch from d2b34ef to dea737a Compare January 9, 2022 13:31
@reyraa reyraa force-pushed the 3954-add-hw-multisig-support branch from ac3879b to 0b88772 Compare January 10, 2022 07:58
@ManuGowda ManuGowda merged commit 52ace16 into release/2.2.0 Jan 10, 2022
@ManuGowda ManuGowda deleted the 3954-add-hw-multisig-support branch January 10, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants