Add ineligible delegates to outside round - Closes #3973 #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com:LiskHQ/lisk-desktop into 3973-add-ineligible-delegates-to-outside-round
reyraa
suggested changes
Dec 4, 2021
There was a problem hiding this comment.
Ineligible delegates are added to the list by this commit. We should adapt the title and explain the acceptance criteria accurately. Otherwise it's hard to review.
I only see indentations changed. What is the logical change applied?
@reyraa I think this issue is a false positive. For some reason this commit was not merged into release and it fixed the problem in this issue. This was the fix in this PR. |
reyraa
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #3973
How was it solved?
Adding 'non-eligible' status to the outside round API call.
How was it tested?
Visually.