Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to Sign multisignature transaction - Closes #3975, Closes #3978 #3987

Merged
merged 20 commits into from
Dec 3, 2021
Merged

Unable to Sign multisignature transaction - Closes #3975, Closes #3978 #3987

merged 20 commits into from
Dec 3, 2021

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Dec 1, 2021 •
edited by ManuGowda
Loading

What was the problem?

This PR resolves #3975

How was it solved?

  • Improved the validation of the multisig registration
    • Please review the unit tests I added. you'll see what kind of configurations I am preventing.
  • Fixed the blocked signatures.
    • I am deleting one of the optional signatures in favour of the mandatory one. I'm also informing the user about this.

How was it tested?

  • Unit tests

@reyraa reyraa changed the base branch from development to release/2.2.0 December 1, 2021 08:37
@reyraa reyraa self-assigned this Dec 1, 2021
@reyraa reyraa changed the title Unable to Sign multisignature transaction - Closes #3975 Unable to Sign multisignature transaction - Closes #3975, Closes #3978 Dec 1, 2021
@reyraa reyraa force-pushed the 3975-patch-multisig-loose-validations branch from 0abe24b to 42ca6ce Compare December 1, 2021 11:44
@reyraa reyraa requested a review from isalga December 1, 2021 11:45
@reyraa reyraa force-pushed the 3975-patch-multisig-loose-validations branch from e4244b5 to f7710d7 Compare December 2, 2021 08:55
@reyraa reyraa requested a review from isalga December 2, 2021 08:56
@reyraa reyraa removed request for isalga and ManuGowda December 2, 2021 15:12
@reyraa reyraa force-pushed the 3975-patch-multisig-loose-validations branch from a1a4fe8 to 731174b Compare December 3, 2021 08:30
@reyraa reyraa merged commit b0f9cd7 into release/2.2.0 Dec 3, 2021
@reyraa reyraa deleted the 3975-patch-multisig-loose-validations branch December 3, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isalga isalga isalga requested changes

@ikem-legend ikem-legend ikem-legend approved these changes

@gadjacobs gadjacobs gadjacobs approved these changes

Assignees

@reyraa reyraa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to Sign multisignature transaction
4 participants
@reyraa @isalga @gadjacobs @ikem-legend