Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix register delegate summary screen - Closes #3962 #3980

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Fix register delegate summary screen - Closes #3962 #3980

merged 3 commits into from
Dec 1, 2021

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Nov 29, 2021

What was the problem?

This PR resolves #3962

How was it solved?

  • The back button was broken in the summary step.
  • The tx fee was in Beddows.

@reyraa reyraa self-assigned this Nov 29, 2021
ManuGowda
ManuGowda approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tested running app. Can we add tests?

@reyraa reyraa removed the request for review from isalga December 1, 2021 11:53
@reyraa reyraa merged commit 36b6c6f into release/2.2.0 Dec 1, 2021
@reyraa reyraa deleted the 3962-delegate-registration-issue branch December 1, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@reyraa reyraa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyraa @ManuGowda