Don't show non send transactions in incoming filter - Closes #382 #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
changed the title
slaweet
changed the title
ginacontrino
force-pushed
the
382-transaction-filters-non-send
branch
from
dfe69a3 to
ece41ea
Compare
ginacontrino
force-pushed
the
382-transaction-filters-non-send
branch
from
ece41ea to
d9df0b1
Compare
ginacontrino
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
see #382
How did I fix it?
filtered non-send transactions out
How to test it?
Given we received one transaction, made one, and also e.g. voted (or any other), it should look like this:
Review checklist