Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix price chart in iOS safari - Closes #377 #387

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Feb 16, 2018

What was the problem?

  • css calc doesn't work in older iOS
  • flexboxgrid has different breakpoints than we

How did I fix it?

  • used min-height: 300px for the chart
  • overridden the flexboxgrid max-width in our class

How to test it?

Open the app on iOS devices ;-)

Review checklist

@slaweet slaweet self-assigned this Feb 16, 2018
@slaweet slaweet requested a review from ginacontrino February 16, 2018 11:04
@slaweet slaweet force-pushed the 377-fix-price-chart-in-safari branch from d5e95c0 to da4e449 Compare February 16, 2018 11:22
@slaweet slaweet force-pushed the 377-fix-price-chart-in-safari branch from da4e449 to 4489929 Compare February 16, 2018 11:56
Copy link
Contributor

@ginacontrino ginacontrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@slaweet slaweet merged commit 5efb4da into 0.1.0 Feb 16, 2018
@slaweet slaweet deleted the 377-fix-price-chart-in-safari branch February 16, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants