Update FlashMessage styles - Closes #3732 #3810
Conversation
ManuGowda
requested review from
ikem-legend,
sridharmeganathan and
ann-vashchenko
and removed request for
ann-vashchenko
src/hooks/useIpc.js
Outdated
|
|
||
| const { ipc } = window; | ||
| // const { ipc } = window; |
There was a problem hiding this comment.
why are we removing the IPC?
There was a problem hiding this comment.
In order to display the message. It will reverted once changes are approved.
src/hooks/useIpc.test.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| import { toast } from 'react-toastify'; | |||
| /* import { toast } from 'react-toastify'; | |||
There was a problem hiding this comment.
I think the tests should exists?
There was a problem hiding this comment.
It will reverted once changes are approved and before merging. It was commented in order to pass lint and supply a deployment test
src/hooks/useIpc.js
Outdated
| @@ -48,7 +53,7 @@ const useIpc = (history) => { | |||
|
|
|||
| ipc.on('update:downloading', (action, { label }) => { | |||
| toast.success(label); | |||
| }); | |||
| }); */ | |||
There was a problem hiding this comment.
This change will be reverted after approved. They were meant to bypass ipc and directly show the message
src/hooks/useIpc.test.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| import { toast } from 'react-toastify'; | |||
| /* import { toast } from 'react-toastify'; | |||
There was a problem hiding this comment.
This change will be reverted after approved.
src/app/index.js
Outdated
| @@ -29,7 +29,8 @@ const App = ({ history }) => { | |||
| const theme = useSelector(state => (state.settings.darkMode ? 'dark' : 'light')); | |||
| const serviceUrl = useSelector(selectServiceUrl); | |||
|
|
|||
| useIpc(history); | |||
| useIpc(); | |||
| // useIpc(history); | |||
| version = '2.0.3', | ||
| releaseSummary = 'This version improves the overall usability and responsiveness of the application UI.', |
There was a problem hiding this comment.
why these default values? if its for testing, reminder to remove them
isalga
dismissed stale reviews from ann-vashchenko, ManuGowda, and ikem-legend
via
4b8ad26
What was the problem?
This PR resolves #3732
How was it solved?
How was it tested?
Force flash message to display always. (Will be removed before merge once PR is approved)