Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto updater does not work - Closes #3760 #3764

Merged
merged 7 commits into from
Sep 13, 2021

Conversation

ManuGowda
Copy link
Contributor

What was the problem?

This PR resolves #3760

How was it solved?

  • Update autoUpdater to use checkForUpdatesAndNotify, using checkForUpdates causes error (due to outdated interface usage)

How was it tested?

  • Install, Build and Run locally
  • Click on check for updates (You should not receive any error)

using checkForUpdates causes error (due to outdated interface usage)
@ManuGowda ManuGowda requested review from reyraa and isalga September 1, 2021 21:50
@ManuGowda ManuGowda self-assigned this Sep 1, 2021
isalga
isalga previously approved these changes Sep 2, 2021
Remove process overriding from base webpack config which induces unintended behaviour
electron-updater require node.js process to work as intended
Create a safe, bi-directional, synchronous bridge across isolated contexts
@ManuGowda ManuGowda force-pushed the 3760-bugfix-auto-updater branch from a1d109e to fa352c6 Compare September 12, 2021 20:43
@ManuGowda ManuGowda requested review from isalga and MichalTuleja and removed request for reyraa September 13, 2021 07:23
@ManuGowda ManuGowda merged commit bd58e9d into release/2.0.1 Sep 13, 2021
@ManuGowda ManuGowda deleted the 3760-bugfix-auto-updater branch September 13, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants