Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0 amount tx notification - Closes #3571 #3752

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

isalga
Copy link
Contributor

@isalga isalga commented Aug 30, 2021

What was the problem?

This PR resolves #3751

How was it solved?

Add amount condition.

How was it tested?

Using electron build.

@isalga isalga requested a review from ManuGowda August 30, 2021 09:28
@isalga isalga self-assigned this Aug 30, 2021
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isalga isalga merged commit 1f340ac into patch/2.0.1 Aug 30, 2021
isalga pushed a commit that referenced this pull request Aug 30, 2021
* Fix bugs for 2.0.1 patch release - Closes #3739, #3742, #3744, #3735 (#3747)

* Fix undefined passphrase when extracting BTC address

* Fix undefined wrong token at send BTC amount validation

* Add Enable BTC setting when logged out

* Increase balance required for reclaim

* Remove unused import

* Fix grammatical mistake

* Remove locale tag

* Add dpos null check

* Load delegate data when explorer account change (#3749)

* Fix 0 amount tx notification - Closes #3571 (#3752)

* Add amount condition before window.Notification

* Add amount condition

* Bump version 2.0.1

Co-authored-by: Oliver Beddows <oliver@lightcurve.io>
@karmacoma karmacoma deleted the 3571-fix-0-amount-tx-notification branch August 30, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants