Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a warning message when user sends the entire balance - Closes #3366 #3729

Merged
merged 5 commits into from
Aug 17, 2021

Conversation

isalga
Copy link
Contributor

@isalga isalga commented Aug 13, 2021

What was the problem?

This PR resolves #3366

How was it solved?

  • Add warning

How was it tested?

Add unit test

@isalga isalga self-assigned this Aug 13, 2021
Copy link
Contributor

@MichalTuleja MichalTuleja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behaviour of that message box is correct, but not very intuitive:

  • Making that message disappear also makes the amount disappear
  • Changing the amount to lower value does not cause the message disappear

Is it possible to track the amount and display the message based on that input?

Copy link
Contributor

@MichalTuleja MichalTuleja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks @isalga

@MichalTuleja MichalTuleja merged commit fd96d31 into development Aug 17, 2021
@MichalTuleja MichalTuleja deleted the 3366-entire-balance-warning branch August 17, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a warning message when user sends the entire balance
3 participants