Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept senderAddress and recipientAddress as filters in api/transactions - Closes #3652 #3696

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

UsamaHameed
Copy link
Contributor

What was the problem?

This PR resolves #3652

How was it solved?

Use filters in api call correctly

How was it tested?

Manually

@UsamaHameed UsamaHameed requested a review from reyraa July 16, 2021 11:24
@UsamaHameed UsamaHameed self-assigned this Jul 16, 2021
@reyraa
Copy link
Contributor

reyraa commented Jul 16, 2021

Good job Usama. The recipient filter is working, although I detected a couple of issues:

  • Since you changed the functionality from address which includes both senderAddress and recipientAddress. The address title should change to sender. There are two places to take care: A. The filter dialog, B. The filter bar above the tx list.
  • The filter dialog doesn't reset when you clean the filter(s) all together or one by one using the filter bar.

@UsamaHameed
Copy link
Contributor Author

Good job Usama. The recipient filter is working, although I detected a couple of issues:

  • Since you changed the functionality from address which includes both senderAddress and recipientAddress. The address title should change to sender. There are two places to take care: A. The filter dialog, B. The filter bar above the tx list.
  • The filter dialog doesn't reset when you clean the filter(s) all together or one by one using the filter bar.

Done ✅

@reyraa reyraa merged commit 9837a7a into development Jul 16, 2021
@reyraa reyraa deleted the 3652-fix-transactions-filters branch July 16, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter is not working as expected in transaction monitoring page
2 participants