Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Register page bugs - Closes #299 #351

Merged
merged 5 commits into from
Feb 14, 2018
Merged

Fix Register page bugs - Closes #299 #351

merged 5 commits into from
Feb 14, 2018

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Feb 13, 2018

What was the problem?

  • There was an unintended error message in last step
  • After removing Material icons, we had to update the icons of our slider checkbox

How to test it?

  • Make sure the error message is not shown after the missing words successfully/correctly entered.
  • Slider checkboxes must match the design guides

Review checklist

@reyraa reyraa self-assigned this Feb 13, 2018
@reyraa reyraa requested a review from yasharAyari February 14, 2018 10:53
@reyraa reyraa merged commit 2f15528 into 0.1.0 Feb 14, 2018
@reyraa reyraa deleted the 299-register-page-bugs branch February 14, 2018 11:35
@reyraa reyraa added ready and removed in progress labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasharAyari yasharAyari yasharAyari approved these changes

Assignees

@reyraa reyraa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyraa @yasharAyari