Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent wallet page crash - Closes #3477 #3480

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

isalga
Copy link
Contributor

@isalga isalga commented Apr 14, 2021

What was the problem?

This PR resolves #3477

How was it solved?

  • Prevent Table to receive undefined data
  • Use data.votes on voting reducer

How was it tested?

Add unit test

@isalga isalga self-assigned this Apr 14, 2021
@isalga isalga requested a review from UsamaHameed April 14, 2021 08:30
Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@isalga isalga requested a review from UsamaHameed April 14, 2021 10:13
@UsamaHameed UsamaHameed changed the base branch from feature-sdk-v5 to 3453-fix-unit-tests April 14, 2021 11:40
@isalga isalga changed the title Prevent wallet page crash Prevent wallet page crash - Closes #3477 Apr 14, 2021
@isalga isalga closed this Apr 14, 2021
@isalga isalga reopened this Apr 14, 2021
@isalga isalga merged commit 2947639 into 3453-fix-unit-tests Apr 14, 2021
@isalga isalga deleted the 3477-prevent-wallet-page-crash branch April 14, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants