Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction broadcast - Closes #3459, #3467 #3468

Merged
merged 17 commits into from
Apr 9, 2021
Merged

Fix transaction broadcast - Closes #3459, #3467 #3468

merged 17 commits into from
Apr 9, 2021

Conversation

UsamaHameed
Copy link
Contributor

@UsamaHameed UsamaHameed commented Apr 7, 2021 •
edited
Loading

What was the problem?

This PR resolves #3459, #3467

How was it solved?

  • Fixes issues with transaction broadcast
  • Added transformer function to convert the broadcasted transaction back to lisk-service format to ensure compat with UI
  • Polyfilled native bigint with toJSON function for JSON.stringify to be able to serialize it.

Additionally:

  • Fixed a few issues where wallet/votes and wallet/delegateProfile views were crashing
  • Fixed an issue with the action votesRetrieved

@UsamaHameed UsamaHameed self-assigned this Apr 7, 2021
@UsamaHameed UsamaHameed requested a review from reyraa April 7, 2021 14:10
reyraa
reyraa suggested changes Apr 8, 2021
View reviewed changes
src/components/toolbox/table/index.js Outdated Show resolved Hide resolved
src/utils/account.js Outdated Show resolved Hide resolved
src/utils/account.js Outdated Show resolved Hide resolved
src/utils/api/account/lsk.js Outdated Show resolved Hide resolved
src/utils/api/transaction/lsk.js Show resolved Hide resolved
src/utils/api/transaction/lsk.js Outdated Show resolved Hide resolved
src/utils/api/transaction/lsk.js Show resolved Hide resolved
src/utils/api/transaction/lsk.js Show resolved Hide resolved
@UsamaHameed UsamaHameed requested a review from reyraa April 9, 2021 08:08
@UsamaHameed UsamaHameed merged commit 0a11e3b into feature-sdk-v5 Apr 9, 2021
@UsamaHameed UsamaHameed deleted the 3459-adapt-tx-broadcast branch April 9, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyraa reyraa reyraa approved these changes

Assignees

@UsamaHameed UsamaHameed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UsamaHameed @reyraa