Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update account visual on address change - Closes #335 #341

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Update account visual on address change - Closes #335 #341

merged 1 commit into from
Feb 13, 2018

Conversation

ginacontrino
Copy link
Contributor

What was the problem?

The visual didnt update on address change in the send component, see #335

How did I fix it?

How to test it?

this is cool to test, follow steps from #335 and see the "magic" :D

Review checklist

@ginacontrino ginacontrino self-assigned this Feb 13, 2018
@ginacontrino ginacontrino requested a review from slaweet February 13, 2018 10:26
slaweet
slaweet approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ginacontrino ginacontrino merged commit 95ce3d5 into 0.1.0 Feb 13, 2018
@ginacontrino ginacontrino deleted the 335-update-account-visual branch February 13, 2018 10:42
@ginacontrino ginacontrino changed the title Update account visual on address change Update account visual on address change - Closes #335 Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

Assignees

@ginacontrino ginacontrino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ginacontrino @slaweet