-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open send layover when coming from "send to this address" - Closes #336 #340
Conversation
src/components/send/index.js
Outdated
this.state = { | ||
sendIsActive: false, | ||
sendIsActive: !!this.address || false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|| false
is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right
src/components/send/index.js
Outdated
@@ -39,7 +41,10 @@ class Send extends React.Component { | |||
</span> | |||
<MultiStep finalCallback={this.setSendIsActive.bind(this, false)} | |||
className={styles.wrapper}> | |||
<SendWritable autoFocus={this.state.sendIsActive || window.innerWidth > 1024}/> | |||
<SendWritable | |||
autoFocus={this.state.sendIsActive || window.innerWidth > 1024} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a constants/breakpoints.js
file with 1024
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Gina
What was the problem?
The send layover didn't open, see #336
How did I fix it?
By checking the url props 'address'
Review checklist