Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open send layover when coming from "send to this address" - Closes #336 #340

Merged
merged 3 commits into from
Feb 13, 2018

Conversation

ginacontrino
Copy link
Contributor

What was the problem?

The send layover didn't open, see #336

How did I fix it?

By checking the url props 'address'

Review checklist

this.state = {
sendIsActive: false,
sendIsActive: !!this.address || false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| false is not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

@@ -39,7 +41,10 @@ class Send extends React.Component {
</span>
<MultiStep finalCallback={this.setSendIsActive.bind(this, false)}
className={styles.wrapper}>
<SendWritable autoFocus={this.state.sendIsActive || window.innerWidth > 1024}/>
<SendWritable
autoFocus={this.state.sendIsActive || window.innerWidth > 1024}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a constants/breakpoints.js file with 1024.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gina

@ginacontrino ginacontrino merged commit 5de6103 into 0.1.0 Feb 13, 2018
@ginacontrino ginacontrino deleted the 336-send-to-this-address branch February 13, 2018 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants