Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wallet displays some extra transactions - Closes #278 #297

Merged
merged 3 commits into from
Feb 8, 2018
Merged

Fix wallet displays some extra transactions - Closes #278 #297

merged 3 commits into from
Feb 8, 2018

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Feb 8, 2018 •
edited
Loading

What was the problem?

Account middleware was using state.transactions.address to get transactions, which was not always defined.

How did I fix it?

By using state.transactions.address ? state.transactions.address : state.account.address

How to test it?

Follow steps to reproduce in #278

Review checklist

@slaweet slaweet changed the base branch from development to 0.1.0 February 8, 2018 17:11
@slaweet slaweet self-assigned this Feb 8, 2018
@slaweet slaweet requested a review from ginacontrino February 8, 2018 17:45
ginacontrino
ginacontrino approved these changes Feb 8, 2018
View reviewed changes
Copy link
Contributor

@ginacontrino ginacontrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you

@slaweet slaweet merged commit d8a0c6a into 0.1.0 Feb 8, 2018
@slaweet slaweet deleted the 278-extra-transactions-in-wallet branch February 8, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ginacontrino ginacontrino ginacontrino approved these changes

Assignees

@slaweet slaweet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaweet @ginacontrino