Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "send to this address" - Closes #137 #292

Merged
merged 10 commits into from
Feb 9, 2018
Merged

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Feb 7, 2018

What was the problem?

"Send to this address" in account/address transactions result page was not implemented

How did I fix it?

Implemented it + wrote tests

How to test it?

Compare with design + click "send to this address" and make sure the address field of the send component contains the address

screen shot 2018-02-09 at 08 24 31

screen shot 2018-02-09 at 08 24 47

screen shot 2018-02-09 at 08 37 30

Review checklist

@ginacontrino ginacontrino self-assigned this Feb 7, 2018
@ginacontrino ginacontrino force-pushed the 137-send-to-address branch 2 times, most recently from 8a5e6f0 to d5f104e Compare February 8, 2018 17:34
@ginacontrino ginacontrino force-pushed the 137-send-to-address branch 2 times, most recently from d0e76af to 3f6d7e4 Compare February 9, 2018 07:40
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Gina

@ginacontrino ginacontrino merged commit 46b50c4 into 0.1.0 Feb 9, 2018
@ginacontrino ginacontrino deleted the 137-send-to-address branch February 9, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants