-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "send to this address" - Closes #137 #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
137-send-to-address
branch
2 times, most recently
from
February 8, 2018 17:34
8a5e6f0
to
d5f104e
Compare
ginacontrino
force-pushed
the
137-send-to-address
branch
2 times, most recently
from
February 9, 2018 07:40
d0e76af
to
3f6d7e4
Compare
ginacontrino
force-pushed
the
137-send-to-address
branch
from
February 9, 2018 18:02
068f6f5
to
a60791f
Compare
slaweet
approved these changes
Feb 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Gina
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
"Send to this address" in account/address transactions result page was not implemented
How did I fix it?
Implemented it + wrote tests
How to test it?
Compare with design + click "send to this address" and make sure the address field of the send component contains the address
Review checklist