Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click anywhere on transaction row should go to transaction detail - Closes #271 #289

Merged
merged 8 commits into from
Feb 8, 2018

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Feb 7, 2018

What was the problem?

Only the arrow on transaction row went to detail page

How did I fix it?

  • I made the whole row clickable.
  • The detail view now has links to account pages and transaction page.

Review checklist

@slaweet slaweet self-assigned this Feb 7, 2018
@slaweet slaweet requested a review from ginacontrino February 7, 2018 10:06
@slaweet slaweet changed the base branch from development to 0.1.0 February 7, 2018 10:07
@slaweet slaweet force-pushed the 271-click-whole-transaction-row branch 2 times, most recently from bb301a9 to 2105ccd Compare February 8, 2018 08:26
@slaweet slaweet force-pushed the 271-click-whole-transaction-row branch from e769a4a to 468194c Compare February 8, 2018 16:31
Copy link
Contributor

@ginacontrino ginacontrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@slaweet slaweet merged commit c15d8f9 into 0.1.0 Feb 8, 2018
@slaweet slaweet deleted the 271-click-whole-transaction-row branch February 8, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants