-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction filters - Closes #32 #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
32-transaction-filters
branch
from
January 16, 2018 17:13
6dccbe1
to
6ea3510
Compare
ginacontrino
force-pushed
the
32-transaction-filters
branch
from
January 17, 2018 10:30
3e5e977
to
b906def
Compare
ginacontrino
force-pushed
the
32-transaction-filters
branch
from
January 17, 2018 13:48
aa4a394
to
07bd944
Compare
.. to make switching transactions filter more responsive on slow network connection
... to make it consistent with 25 used in transactions middleware and avoid e2e test failing randomly
slaweet
force-pushed
the
32-transaction-filters
branch
from
January 18, 2018 14:36
718ea79
to
c8f9b35
Compare
slaweet
approved these changes
Jan 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Gina
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The transaction filters were not working
How did I fix it?
How to test it?
Go through and filter!
Review checklist