Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction filters - Closes #32 #211

Merged
merged 9 commits into from
Jan 18, 2018
Merged

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Jan 16, 2018

What was the problem?

The transaction filters were not working

How did I fix it?

  • Implemented All, Incoming and Outgoing
  • Also fixes the incorrect amount display (incorrect styles and +,-)

How to test it?

Go through and filter!

Review checklist

@ginacontrino ginacontrino requested a review from slaweet January 16, 2018 13:23
@ginacontrino ginacontrino force-pushed the 32-transaction-filters branch from 6dccbe1 to 6ea3510 Compare January 16, 2018 17:13
@ginacontrino ginacontrino force-pushed the 32-transaction-filters branch from aa4a394 to 07bd944 Compare January 17, 2018 13:48
Gina Contrino and others added 3 commits January 18, 2018 10:51
.. to make switching transactions filter more responsive on slow
network connection
... to make it consistent with 25 used in  transactions middleware
and avoid e2e test failing randomly
@slaweet slaweet force-pushed the 32-transaction-filters branch from 718ea79 to c8f9b35 Compare January 18, 2018 14:36
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Gina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants