Fix vertical responsiveness of L breakpoint - Closes #170 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
170-l-breakpoint
branch
from
bb46cb1 to
432ac09
Compare
ginacontrino
force-pushed
the
170-l-breakpoint
branch
from
432ac09 to
6c0b36c
Compare
ginacontrino
requested review from
yasharAyari,
reyraa and
slaweet
and removed request for
yasharAyari
slaweet
suggested changes
Jan 15, 2018
ginacontrino
force-pushed
the
170-l-breakpoint
branch
from
6c0b36c to
b4f443e
Compare
ginacontrino
force-pushed
the
170-l-breakpoint
branch
from
b4f443e to
c0473de
Compare
|
It is better, the send can be fixed in a separate ticket, but IMO the top part has too much margin that takes space that could be used for the content
|
slaweet
previously approved these changes
Jan 16, 2018
ginacontrino
force-pushed
the
170-l-breakpoint
branch
from
24edb3f to
634b60b
Compare
slaweet
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The box and side menu sizing were not quite right yet for the breakpoints
How did I fix it?
Media queries
What does it look like?
Review checklist