Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create standalone send page - Closes #1495 #1525

Merged
merged 17 commits into from
Dec 4, 2018

Conversation

osvaldovega
Copy link
Contributor

What issue have I solved?

-- #1495

How have I implemented/fixed it?

Working on it.
Standalone page created, right now navigation is possible and route file updated to properly use /send in browser.

How has this been tested?

Review checklist

Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some buttons are mis-alligned:
screen shot 2018-11-29 at 16 31 22
screen shot 2018-11-29 at 16 32 26
Here the buttons should be wider (check https://taikonauten.invisionapp.com/d/main/#/console/15987783/331614914/preview):
screen shot 2018-11-29 at 16 33 28
screen shot 2018-11-29 at 16 35 13

@slaweet slaweet changed the base branch from 1.7.0 to 1.8.0 November 29, 2018 16:22
@osvaldovega
Copy link
Contributor Author

requested changes are fixed, branch updated

src/components/multiStep/index.js Show resolved Hide resolved
src/components/resultBox/resultBox.js Outdated Show resolved Hide resolved
@osvaldovega osvaldovega merged commit 16f0347 into 1.8.0 Dec 4, 2018
@osvaldovega osvaldovega deleted the 1495-create-standalone-send-page branch December 4, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants