Improve design bookmarks - Close #1375 #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
suggested changes
Oct 24, 2018
There was a problem hiding this comment.
- Color of label "Send to address" shouldn't be black when input focused (check design to get the hex value)
- Color of bookmark title and address shouldn't be black (check design to get the hex value)
- regression: empty, unfocussed address field has label too high - compare https://jenkins.lisk.io/test/lisk-hub/PR-1388/#/wallet to https://jenkins.lisk.io/test/lisk-hub/1.5.0/#/wallet
slaweet
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
-- #1375
How have I implemented/fixed it?
CHanged styles according to designs
How has this been tested?
Compare bookmarks to desings
Review checklist