Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jest tests to pass in Jenkins - Closes #1302 #1348

Merged
merged 8 commits into from
Oct 15, 2018

Conversation

bmaggi-lisk
Copy link
Contributor

What issue have I solved?

-- #1302

How have I implemented/fixed it?

  1. Add missing translation
  2. Uncomment jest test from Jenkinsfile

How has this been tested?

npm run test-jest

Review checklist

@bmaggi-lisk bmaggi-lisk self-assigned this Oct 12, 2018
@bmaggi-lisk bmaggi-lisk changed the base branch from development to 1.5.0 October 12, 2018 13:25
@slaweet slaweet changed the title fix jenkins jest - Closes #1302 Fix jest tests to pass in Jenkins - Closes #1302 Oct 12, 2018
@slaweet slaweet changed the base branch from 1.5.0 to development October 15, 2018 09:21
@slaweet slaweet changed the base branch from development to 1.5.0 October 15, 2018 09:21
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Ben.

@bmaggi-lisk bmaggi-lisk merged commit 27fb0ff into 1.5.0 Oct 15, 2018
@bmaggi-lisk bmaggi-lisk deleted the 1302-fix-jenkins-jest branch October 18, 2018 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants