Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove passphrase when locking an account - Closes #1022, #1031 #1027

Conversation

faival
Copy link
Contributor

@faival faival commented Jul 12, 2018

What was the problem?

#1022

How did I fix it?

  • account.address was used in activePeerSet to reflect which url the account should connect to.
  • this was misleading and colliding with account.address ID, I've renamed the key to be peerAddress, so that is not longer confusing.

How to test it?

Review checklist

@faival faival self-assigned this Jul 13, 2018
@faival faival force-pushed the 1022-locking-an-account-should-have-e2e-tests-core-1.0.0-migration branch from 5076435 to 3f3fd88 Compare July 13, 2018 08:28
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @faival

@faival faival merged commit ffae635 into 1.0.0 Jul 13, 2018
@faival faival changed the title Fix remove passphrase when locking an account - Closes #1022 Fix remove passphrase when locking an account - Closes #1022, #1031 Jul 13, 2018
@faival faival deleted the 1022-locking-an-account-should-have-e2e-tests-core-1.0.0-migration branch July 13, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants