Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling of the WalletConnect hooks #4482

Closed
Tracked by #4040
reyraa opened this issue Sep 21, 2022 · 0 comments
Closed
Tracked by #4040

Improve error handling of the WalletConnect hooks #4482

reyraa opened this issue Sep 21, 2022 · 0 comments
Assignees
@reyraa
Labels
type: improvement
Milestone
Sprint 86

Comments

@reyraa
Copy link
Contributor

reyraa commented Sep 21, 2022 •
edited
Loading

Description

We have to account for situations where the response of the bridge does not match our expectation.

Acceptance Criteria

Ensure we cover the following situations:

  • The client.setUrl responds with error.
  • The connection proposal event doesn't respond with the expected data.
  • The transaction request data doesn't match our expected data schema.
@reyraa reyraa self-assigned this Sep 21, 2022
@sridharmeganathan sridharmeganathan mentioned this issue Sep 21, 2022
Closed
5 tasks
@sridharmeganathan sridharmeganathan added this to the Sprint 85 milestone Oct 11, 2022
@sridharmeganathan sridharmeganathan moved this from Backlog to Todo in Lisk Desktop Version 3.0.0 Oct 11, 2022
@reyraa reyraa mentioned this issue Oct 30, 2022
Merged
5 tasks
@reyraa reyraa mentioned this issue Oct 31, 2022
Merged
soroushm pushed a commit that referenced this issue Nov 2, 2022
Merge pull request #4546 from LiskHQ/4482-improve-error-handling
ac96f28 
 Improve error handling of the WalletConnect hooks - Closes #4482
Repository owner moved this from Todo to Done in Lisk Desktop Version 3.0.0 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyraa reyraa

Labels
type: improvement
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 86
Development

No branches or pull requests
2 participants
@reyraa @sridharmeganathan