Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to send a transaction from a specific multisignature account #4141

Closed
przemerr opened this issue Feb 3, 2022 · 5 comments
Closed
Assignees
Milestone

Comments

@przemerr
Copy link

przemerr commented Feb 3, 2022

Expected behavior

User should be able to send a transaction from any multisignature account

Actual behavior

User is unable to send a transfer transaction from a multisingature account that has one required key that doesn't belong to senders account (example of the account https://testnet-service.lisk.io/api/v2/accounts?address=lsko3qy92jx8g9h4zhghdbey6n753k434wmpeoeaw)

Steps to reproduce

Create a multisignature account with one required key that doesn't belong to senders account (example https://testnet-service.lisk.io/api/v2/accounts?address=lsko3qy92jx8g9h4zhghdbey6n753k434wmpeoeaw). After creating it, try sending a transfer transaction with the account

Which version(s) does this affect? (Environment, OS, etc...)

Windows Lisk Desktop 2.2.0, doesn't affect 2.1.0.

@ManuGowda ManuGowda added this to the Sprint 67 milestone Feb 3, 2022
@ManuGowda
Copy link
Contributor

While sign and send, the below screen appears.

Screenshot 2022-02-03 at 2 04 06 PM

@reyraa
Copy link
Contributor

reyraa commented Feb 7, 2022

@ManuGowda This account is impractical and with the current validations of the multisig registration form, you shouldn't be able to create such accounts.

We talked about this a couple of times and decided not to support such accounts.

Nonetheless, if there's an explainable use case for a multisig account with a single member, we can go ahead and make Lisk Desktop accept such accounts. In such case, we should update the multisig registration form validation to accept accounts with a single member.

@przemerr
Copy link
Author

przemerr commented Feb 7, 2022

@reyraa There are users that have this type of account (mainly by mistake), and you can register those type of accounts in 2.2.0
image

the sending from those accounts worked in 2.1.0

@przemerr
Copy link
Author

przemerr commented Feb 7, 2022

they are still somewhat useful if you're a delegate, since you sign blocks with your delegate account, and send tokens with the other signature.

@reyraa
Copy link
Contributor

reyraa commented Feb 7, 2022

Yes, this is a limited yet valid use case. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants