Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for the sign multisignature transaction screen #4102

Closed
Tracked by #4065
reyraa opened this issue Jan 24, 2022 · 0 comments · Fixed by #4144
Closed
Tracked by #4065

Add e2e tests for the sign multisignature transaction screen #4102

reyraa opened this issue Jan 24, 2022 · 0 comments · Fixed by #4144
Assignees
@isalga
Labels
type: test
Milestone
Sprint 68

Comments

@reyraa
Copy link
Contributor

reyraa commented Jan 24, 2022 •
edited by ManuGowda
Loading

Description

As a part of #4065 we'd like to introduce e2e test coverage for the sign multisignature transaction screen. The e2e tests should test the following user journeys.

Acceptance criteria

  • Users must be able to paste a raw tx into the input.
  • Users must be able to load a tx json file.
  • Once loaded, they should be able to navigate to the summary and read:
    • Tx title
    • Sender
    • Tx asset (specific for each type. I assume we should only test 2 types for the sake of run duration)
    • Fee
    • nonce
    • Signed members
    • Remaining members
  • Users must be able to sign the tx. If the tx is not fully signed, they should be able to copy and download the tx.
    • If it is not fully signed, the send button shouldn't appear
  • On a dedicated scenario, users must be able to sign the tx and send.
  • If Lisk Desktop throws an unwanted error that fails the e2e test in a random basis, it should be resolved.

Additional information

  • Sign transaction using second passphrase scenario
  • Sign transaction using mandatory and optional combination
    • M, M (2 required signatures)
    • M, O, O (2 required signatures)
@reyraa reyraa mentioned this issue Jan 24, 2022
Closed
10 tasks
@reyraa reyraa changed the title Add e2e tests for the sign Multisignature transaction screen Add e2e tests for the sign multisignature transaction screen Jan 24, 2022
@sridharmeganathan sridharmeganathan added this to the Sprint 67 milestone Feb 1, 2022
@isalga isalga mentioned this issue Feb 7, 2022
Merged
6 tasks
@reyraa reyraa mentioned this issue Feb 16, 2022
Closed
3 tasks
@isalga isalga mentioned this issue Feb 21, 2022
Closed
isalga pushed a commit that referenced this issue Feb 21, 2022
@ManuGowda @eniolam1000752
Add e2e tests for the sign multisignature transaction screen - Closes #…
67dbc5f 
…4102 (#4144)

* Set up scenarios

* Add selectors

* Fill scenarios

* Add selectors

* Fix first scenario

* ✨ Introduce stale bot

* Implement scenarios (WIP)

* Add third scenario

* Add scenario

* Add scenario

* Add second passphrase scenario

* Reorder tests and send first multisignature register tx

* Send tx using second passphrase

* Update transactions info

* Add paste command

* Move mock tx to feature

* Update feature steps

* Fix tx members order

* Use env url

* Add scroll

* Fix second passphrase send tx e2e

* Check latest tx in monitor screen

* Click on load latest

* Rename parameters

* Move mockTx to file

* Revert typo

* Use account2P

* Update number of transactions

* Test clipboard

* Remova stale

* reduce wait time

* Wait before navigating to transactions monitor

* remove load latest click

Co-authored-by: ManuGowda <manu@lightcurve.io>
Co-authored-by: Manu <ManuGowda@users.noreply.github.com>
Co-authored-by: Eniola Olatunji <eniolam1000752@gmail.com>
gadjacobs pushed a commit that referenced this issue Feb 21, 2022
@ManuGowda @eniolam1000752 @gadjacobs
Add e2e tests for the sign multisignature transaction screen - Closes #…
af680dd 
…4102 (#4144)

* Set up scenarios

* Add selectors

* Fill scenarios

* Add selectors

* Fix first scenario

* ✨ Introduce stale bot

* Implement scenarios (WIP)

* Add third scenario

* Add scenario

* Add scenario

* Add second passphrase scenario

* Reorder tests and send first multisignature register tx

* Send tx using second passphrase

* Update transactions info

* Add paste command

* Move mock tx to feature

* Update feature steps

* Fix tx members order

* Use env url

* Add scroll

* Fix second passphrase send tx e2e

* Check latest tx in monitor screen

* Click on load latest

* Rename parameters

* Move mockTx to file

* Revert typo

* Use account2P

* Update number of transactions

* Test clipboard

* Remova stale

* reduce wait time

* Wait before navigating to transactions monitor

* remove load latest click

Co-authored-by: ManuGowda <manu@lightcurve.io>
Co-authored-by: Manu <ManuGowda@users.noreply.github.com>
Co-authored-by: Eniola Olatunji <eniolam1000752@gmail.com>
gadjacobs added a commit that referenced this issue Feb 21, 2022
@gadjacobs
Revert "Add e2e tests for the sign multisignature transaction screen - …
c00a8b5 
…Closes #4102 (#4144)"

This reverts commit 67dbc5f.
gadjacobs added a commit that referenced this issue Feb 22, 2022
@gadjacobs
Revert "Add e2e tests for the sign multisignature transaction screen - …
84e40d0 
…Closes #4102 (#4144)"

This reverts commit 67dbc5f.
gadjacobs added a commit that referenced this issue Feb 22, 2022
@gadjacobs
Revert "Add e2e tests for the sign multisignature transaction screen - …
da217a6 
…Closes #4102 (#4144)"

This reverts commit 67dbc5f.
gadjacobs added a commit that referenced this issue Mar 1, 2022
@gadjacobs
Revert "Add e2e tests for the sign multisignature transaction screen - …
80df1b9 
…Closes #4102 (#4144)"

This reverts commit 67dbc5f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isalga isalga

Labels
type: test
Projects
None yet
Milestone
Sprint 68
Development

Successfully merging a pull request may close this issue.

Add e2e tests for the sign multisignature transaction screen - Closes #4102 LiskHQ/lisk-desktop
4 participants
@reyraa @isalga @ManuGowda @sridharmeganathan